Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Add assertion and helpful message for marlin24 compressed models #11388

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[Misc] Add assertion and helpful message for marlin24 compressed models #11388

merged 1 commit into from
Dec 23, 2024

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Dec 21, 2024 •
edited
Loading

Summary

  • A common reported issue for users when running marlin24 compressed models
  • Add an assertion and helpful message about setting the dtype

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@dsikka dsikka marked this pull request as ready for review December 21, 2024 01:47
@dsikka
Copy link
Contributor Author

dsikka commented Dec 21, 2024

@mgoin
@robertgshaw2-neuralmagic

mgoin
mgoin approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 23, 2024
@DarkLight1337 DarkLight1337 merged commit b866cdb into vllm-project:main Dec 23, 2024
69 checks passed
ayylemao pushed a commit to ayylemao/vllm that referenced this pull request Dec 24, 2024
@dsikka
[Misc] Add assertion and helpful message for marlin24 compressed mode…
d4eacfb 
…ls (vllm-project#11388)
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@dsikka @BKitor
[Misc] Add assertion and helpful message for marlin24 compressed mode…
f41d5e5 
…ls (vllm-project#11388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsikka @mgoin @DarkLight1337